Removes the use of the custom OpenClass annotation and the associated kotlin-allopen plugin#595
Closed
314systems wants to merge 3 commits intoVREMSoftwareDevelopment:mainfrom
Closed
Removes the use of the custom OpenClass annotation and the associated kotlin-allopen plugin#595314systems wants to merge 3 commits intoVREMSoftwareDevelopment:mainfrom
OpenClass annotation and the associated kotlin-allopen plugin#595314systems wants to merge 3 commits intoVREMSoftwareDevelopment:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request removes the custom @OpenClass annotation and the associated kotlin-allopen plugin, replacing them with Mockito's inline MockMaker for testing. This simplifies the build configuration by eliminating the need to explicitly make Kotlin classes open for mocking purposes.
Changes:
- Removed the
kotlin-allopenplugin and associated configuration from build files - Deleted the custom
OpenClassannotation definition - Removed all usages of the
@OpenClassannotation from production classes - Added Mockito's
mock-maker-inlineconfiguration to enable mocking of final Kotlin classes - Added
openmodifier to two specific methods (selectionsproperty andcolormethod) that are overridden by subclasses
Reviewed changes
Copilot reviewed 41 out of 44 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| build.gradle | Removed kotlin-allopen plugin classpath dependency |
| app/build.gradle | Removed kotlin-allopen plugin and allOpen configuration block |
| app/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker | Added mock-maker-inline configuration to enable mocking of final classes |
| app/src/main/kotlin/com/vrem/annotation/OpenClass.kt | Deleted the custom OpenClass annotation file |
| app/src/main/kotlin/com/vrem/wifianalyzer/wifi/filter/adapter/BasicFilterAdapter.kt | Made selections property open for overriding in SSIDAdapter |
| app/src/main/kotlin/com/vrem/wifianalyzer/wifi/filter/adapter/EnumFilterAdapter.kt | Made color method open for overriding in StrengthAdapter |
| Multiple production class files (46 files) | Removed @OpenClass annotations and associated imports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Thanks for the PR, but we will pass on this one.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #595 +/- ##
===========================================
- Coverage 97.83% 0 -97.84%
===========================================
Files 121 0 -121
Lines 2581 0 -2581
Branches 211 0 -211
===========================================
- Hits 2525 0 -2525
+ Misses 19 0 -19
+ Partials 37 0 -37 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenClassannotation and the associatedkotlin-allopenpluginChecklist (required before marking ready)
app/src/test/)